Skip to content

fix: browser and console#2064

Merged
RohitKushvaha01 merged 4 commits intoAcode-Foundation:mainfrom
RohitKushvaha01:fix_console
May 4, 2026
Merged

fix: browser and console#2064
RohitKushvaha01 merged 4 commits intoAcode-Foundation:mainfrom
RohitKushvaha01:fix_console

Conversation

@RohitKushvaha01
Copy link
Copy Markdown
Member

No description provided.

@RohitKushvaha01 RohitKushvaha01 marked this pull request as draft April 27, 2026 09:05
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 27, 2026

Greptile Summary

This PR adds edge-to-edge display support to BrowserActivity for API 30+, using setDecorFitsSystemWindows(false) and a WindowInsets.Type.systemBars()-based listener to apply correct padding to the browser view. The API guard correctly scopes both the window flag and the insets listener to API 30+, addressing a previous double-padding regression.

Confidence Score: 4/5

Safe to merge with minor outstanding issues noted in previous and current review threads

No P0/P1 issues introduced by this PR; one P2 suggestion around display cutout handling, and two pre-existing issues flagged in prior review threads that remain unresolved

src/plugins/browser/android/com/foxdebug/browser/BrowserActivity.java — insets listener could be extended to cover display cutout areas

Important Files Changed

Filename Overview
src/plugins/browser/android/com/foxdebug/browser/BrowserActivity.java Adds API 30+ edge-to-edge insets handling using modern WindowInsets.Type API, correctly guarded by SDK version check; display cutout insets not merged into padding

Sequence Diagram

sequenceDiagram
    participant OS as Android OS (API 30+)
    participant W as Window
    participant D as DecorView
    participant B as Browser (View)

    OS->>W: dispatch WindowInsets
    W->>W: setDecorFitsSystemWindows(false)
    note over W: DecorView stops consuming insets itself
    W->>D: pass insets down
    D->>B: onApplyWindowInsets(insets)
    B->>B: getInsets(systemBars()) → left/top/right/bottom
    B->>B: setPadding(left, top, right, bottom)
    B-->>D: consumeSystemWindowInsets()
Loading

Reviews (4): Last reviewed commit: "use newer api" | Re-trigger Greptile

Comment thread src/plugins/browser/android/com/foxdebug/browser/BrowserActivity.java Outdated
Comment thread src/plugins/browser/android/com/foxdebug/browser/BrowserActivity.java Outdated
Comment thread src/plugins/browser/android/com/foxdebug/browser/BrowserActivity.java Outdated
@RohitKushvaha01
Copy link
Copy Markdown
Member Author

@greptileai

@RohitKushvaha01 RohitKushvaha01 marked this pull request as ready for review April 27, 2026 09:45
@UnschooledGamer
Copy link
Copy Markdown
Member

@RohitKushvaha01 deprecated methods not to be handled?

@RohitKushvaha01
Copy link
Copy Markdown
Member Author

@greptileai

@RohitKushvaha01 RohitKushvaha01 merged commit a028798 into Acode-Foundation:main May 4, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants